Files
e84148d189 v0.2.0-rc.2: P0 hardening — Pi headless, test state isolation, advice fixes (#21)
P0 (correctness):

1. PEPA_HEADLESS=1 guard in extensions/mineflayer-bridge.ts. When `pi -p`
   spawns a subprocess (banter, coach, planner, reflect, auto-patch), the
   bridge no longer attempts a second MC connect — the hybrid runtime
   already owns the nickname. runtime/pi-bridge.js sets the env var on
   every spawn. Root cause of the "two pepa_bot's racing for the slot"
   bug seen in reply-pi stderr.

2. Test state isolation in runtime/config.js. When running under the node
   test runner (detected via execArgv/argv) — or when PEPA_STATE_DIR is
   set — stateDir redirects to /tmp/pepa-test-state-<pid>/. log.js,
   scenario-memory, world-journal, and knowledge.db all follow.
   `npm test` no longer pollutes live scenarios.jsonl, world-journal.jsonl,
   or daily log files. Verified empirically: post-fix run added 0 test
   rows to the live scenarios file. Cleaned ~550 historical test rows
   from live state in the same change.

3. defendReflex outcome reporting (runtime/reflex.js). Previously a
   creeper-rule override marked the lesson succeeded=false BEFORE the
   flee skill returned. Now dispatchDefendFlee accepts {lessonId} and
   the onComplete fires reportAdviceOutcome with the actual flee result.

4. Mode-name → skill-id translation in runtime/coach/advice.js. Pi-coach
   occasionally returns prefer_skill values that are mode names
   ("night_shelter", "self_preservation", "hunger"). normalisePreferSkill
   maps these to SAFE_OVERRIDES entries before dispatch. Also handles
   "tunnel-out", "survive_flee", "survive flee" shapes.

New behavior:

5. Self-reflection loop (runtime/coach/reflect.js). Every 30 min, the
   bot asks Pi: "Are you making progress, or stuck in a loop? What
   should you do differently?" Pi answers with a verdict
   (progress/loop/recovering/idle/emergency), summary, next-action, and
   0-N new lessons. The reflection is written to
   state/<host>/reflections/<ts>.md and lessons land in the DB with
   source="pi-reflect". Rate-limited to 2 calls/hour. Wired through
   bot.js with the existing askPi + lastSnapshot accessor.

Tests: 246/246 green (+9 new: 6 advice mode-name + 4 reflect).

Co-authored-by: Yuriy Mayatnikov <mayatnikov@me.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-27 14:10:28 +03:00

48 lines
1.6 KiB
JavaScript

// Spawn `pi -p "<prompt>"` as a one-shot subprocess and stream stdout/stderr
// to the caller. Used for headless escalation: the bot's reflex / TUI can ask
// Pi a single question without keeping a long-lived TUI session open.
import { spawn } from "node:child_process";
import { info, warn } from "./log.js";
// Resolve `pi` lazily — user has it on PATH via vite-plus shim.
const PI_BIN = process.env.PI_BIN || "pi";
export function askPi({ prompt, onChunk, onDone, cwd, signal }) {
const startedAt = Date.now();
info("pi-bridge", `spawning pi -p (${prompt.length} chars)`);
const child = spawn(PI_BIN, ["-p", prompt], {
cwd: cwd || process.cwd(),
// PEPA_HEADLESS=1 tells extensions/mineflayer-bridge.ts (loaded by the
// Pi subprocess) NOT to open its own MC connection. The hybrid runtime
// already owns the nickname; a second connection races for the slot.
env: { ...process.env, CI: "1", PEPA_HEADLESS: "1" },
stdio: ["ignore", "pipe", "pipe"],
signal,
});
child.stdout.setEncoding("utf8");
child.stderr.setEncoding("utf8");
child.stdout.on("data", (chunk) => {
onChunk?.({ stream: "stdout", text: chunk });
});
child.stderr.on("data", (chunk) => {
onChunk?.({ stream: "stderr", text: chunk });
});
child.on("error", (err) => {
warn("pi-bridge", `pi subprocess failed to start: ${err?.message ?? err}`);
onDone?.({ code: -1, durationMs: Date.now() - startedAt, error: String(err) });
});
child.on("exit", (code) => {
const durationMs = Date.now() - startedAt;
info("pi-bridge", `pi exited code=${code} after ${durationMs}ms`);
onDone?.({ code: code ?? -1, durationMs });
});
return child;
}